fix(PluginSettings): improve chip contrast and enable custom chip styles.#4714
Open
aravind4799 wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
fix(PluginSettings): improve chip contrast and enable custom chip styles.#4714aravind4799 wants to merge 1 commit intokubernetes-sigs:mainfrom
aravind4799 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aravind4799 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the color contrast issue for the "User-installed" chip in the Plugin Settings. The previous color combination (#ffffff on #0288d1) had a contrast ratio of 3.85:1, which failed the WCAG AA requirement of 4.5:1. This change updates the background color to
#015493to meet accessibility standards.Related Issue
Fixes #4592
Changes
typeLabelsdefinition.#015493.Chipcomponent for custom styling.Screenshots
Before:
After:
Notes for the Reviewer